Skip to content

Commit d8f56ab

Browse files
RobFaiemderriey
andcommitted
Apply suggestions from code review
Co-Authored-By: Mickaël Derriey <mderriey@gmail.com>
1 parent 645b55b commit d8f56ab

4 files changed

+8
-9
lines changed

PwshZendesk.psd1

-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@
9797
'Get-Problem', 'Get-ZendeskProblem'
9898
'Get-SearchCount', 'Get-ZendeskSearchCount'
9999
'Get-SharingAgreement', 'Get-ZendeskSharingAgreement'
100-
'Get-SharingAgreement', 'Get-ZendeskSharingAgreement'
101100
'Get-SuspendedTicket', 'Get-ZendeskSuspendedTicket'
102101
'Get-Tag', 'Get-ZendeskTag'
103102
'Get-Ticket', 'Get-ZendeskTicket'

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
![Build Status]
44

55
PwshZendesk is a Zendesk Support API client for Powershell.
6-
PwshZendesk supports Powershell versions 5.0, 5.1, 6, and 7 on all platforms.
6+
PwshZendesk supports Powershell versions 5.1, 6, and 7 on all platforms.
77

88

99
## Getting Started
@@ -22,7 +22,7 @@ Head to Admin => Channels => API and click the `+` under "Token Access"
2222

2323
### Installing
2424

25-
PwshZendesk supports Powershell versions 5.0, 5.1, 6, and 7 on all platforms.
25+
PwshZendesk supports Powershell versions 5.1, 6, and 7 on all platforms.
2626

2727
It is recommended to install PwshZendesk from the [PowerShell Gallery]:
2828

functions/New-SharingAgreement.ps1

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ function New-SharingAgreement {
44
.SYNOPSIS
55
Creates a sharing agreement.
66
.DESCRIPTION
7-
Creatas a sharing agreement. Requires sharing to be enabled on the Zendesk instance. For more information see: https://support.zendesk.com/hc/en-us/articles/203661466-Sharing-tickets-with-other-Zendesk-Support-accounts
7+
Creates a sharing agreement. Requires sharing to be enabled on the Zendesk instance. For more information see: https://support.zendesk.com/hc/en-us/articles/203661466-Sharing-tickets-with-other-Zendesk-Support-accounts
88
.EXAMPLE
99
PS C:\> New-ZendeskSharingAgreement -RemoteSubdomain 'Foo'
1010
1111
Creates a new sharing agreement with the Foo Zendesk Support instance.
1212
#>
1313
[OutputType([PSCustomObject])]
14-
[CMDletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'High')]
14+
[CmdletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'High')]
1515
Param (
1616
# Name of this sharing agreement
1717
[Parameter(Mandatory = $false)]

functions/Update-SharingAgreement.ps1

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ function Update-SharingAgreement {
1616
[CmdletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'High')]
1717
Param (
1818
# Unique Id of the group to retrieve
19-
[Parameter(Mandatory = $false)]
19+
[Parameter(Mandatory = $true)]
2020
[ValidateRange(1, [Int64]::MaxValue)]
2121
[Int64]
2222
$Id,
2323

24-
# Unique Id of the group to retrieve
25-
[Parameter(Mandatory = $false)]
24+
# The status of the agreement
25+
[Parameter(Mandatory = $true)]
2626
[ValidateSet('accepted', 'declined', 'pending', 'inactive')]
2727
[String]
2828
$Status,
@@ -43,7 +43,7 @@ function Update-SharingAgreement {
4343
}
4444
}
4545

46-
if ($PSCmdlet.ShouldProcess($Id, 'Update Group Name.')) {
46+
if ($PSCmdlet.ShouldProcess($Id, 'Update Sharing Agreement.')) {
4747
$result = Invoke-Method -Context $Context -Method 'Put' -Path $path -Body $body -Verbose:$VerbosePreference
4848
$result
4949
}

0 commit comments

Comments
 (0)