Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Parkingspace and Workspace to Space #282

Open
jbkoh opened this issue Nov 28, 2024 · 0 comments
Open

Move Parkingspace and Workspace to Space #282

jbkoh opened this issue Nov 28, 2024 · 0 comments

Comments

@jbkoh
Copy link

jbkoh commented Nov 28, 2024

Currently both ParkingSpace and Workspace are subclasses of Zone. However, similar to Rooms, both ParksingSpace and Workspace have some space codes and treated as the same abstraction level of Rooms in floorplans. A counter example is the Office class. Office is an area which can be a room or an open area, which is currently a subclass of Room. I think Office and Workspace should be in the same subtree of the class hierarchy instead of one being a Zone and the other one being a Room.

IFC's definition of space is I think very informative, which Brick originally adopted.

Spaces are areas or volumes that provide for certain functions within a building.

Based on this definition, Workspace is serving a purpose and thus should be a Space. HVAC_Zone is auxiliary to the purpose of the corresponding space, and thus should be a Zone.

Another drastic solution would be merging the concept of Space and Zone because the distinction is often not clear and not useful. In fact, IFC defines zones to be "A zone is a group of spaces, partial spaces or other zones.", which may hint that we need to be able to arbitrarily represent a part or a collection of spaces, and if a zone can be a part of a space, maybe just call them all spaces instead.

In summary, my preference is to clearly define Space based on IFC and move Workspace/ParkingSpace out of Zone based on that. Another possible, but less preferred, option is to merge the concept of Zone/Space to make Space more generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant