Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for process management #59

Closed
RealOrangeOne opened this issue Jun 21, 2024 · 2 comments · Fixed by #88
Closed

Improve test coverage for process management #59

RealOrangeOne opened this issue Jun 21, 2024 · 2 comments · Fixed by #88
Labels
database-backend Issues relating to the database backend
Milestone

Comments

@RealOrangeOne
Copy link
Owner

Ensuring the db_worker command behaves correctly is critical.

  • Does it terminate cleanly on ctrl+c?
  • Does it terminate cleanly on SIGTERM, SIGINT and SIGKILL?
  • What if a task raises an exception it's not expected to?

All of the above should be the case whether there's a task currently running or not. And what happens to the task when this does happen?

@JaeHyuckSa
Copy link
Contributor

@RealOrangeOne I saw the updates on this issue, and it looks like the current PR has covered a lot. I'd like to help—are there any remaining test cases or areas that still need attention?

@RealOrangeOne
Copy link
Owner Author

Windows improvements are the main things left if you fancy giving them a look: #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database-backend Issues relating to the database backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants