Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uploading patch resources #261

Open
pingdynasty opened this issue Dec 11, 2021 · 3 comments
Open

Add support for uploading patch resources #261

pingdynasty opened this issue Dec 11, 2021 · 3 comments
Assignees

Comments

@pingdynasty
Copy link
Collaborator

We should support adding resources to a patch, such as samples and wavetables.

The easiest way to achieve this will be to simply add support for '.wav' source files, and make sure they are not visualised as text.
Instead there should be a 'Store' button that sends and saves the resource to a connected OWL.
(with confirmation: This will overwrite any existing resource with the name XYZ.wav)

@antisvin
Copy link

We should probably reserve some extension like .bin or .dat for uploading LUTs or anything else that is not stored in WAV format

@pingdynasty
Copy link
Collaborator Author

And/or allow the patch author to mark an uploaded file as a resource.

Meanwhile .wav feels like a useful, safe (are there many wav viruses out there?) step forward which doesn't require storing more metadata. Maybe adding .dat is also safe - and useful?

@antisvin
Copy link

Marking a file as resource and supporting a specific extension for non-WAV resources achieve the same thing, I don't think we need both. I've suggested choosing a generic extension simply because it seems like it would take less work.

For .dat files we will only store data as is (no metadata to parse, can't preview them, etc), so it certainly can't be less safe than storing WAVs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants