Run Yargs in strict mode and return exit code 1 if the command is invalid #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
reviewed
May 29, 2018
cli/index.ts
Outdated
| .fail((message, error) => { | ||
| console.log(error.stack); | ||
| if (message) { | ||
| console.log(message); |
There was a problem hiding this comment.
I would also pring yargs usage info here yargs.help()
|
Thanks, @brushmate! Could you please add usage help as per comment? |
|
You are right. That would be nicer. I will do so tomorrow. |
brushmate
force-pushed
the
show-error-when-subcommand-is-missing
branch
from
722a062
to
4ee0f0f
Compare
|
After reading more on Yargs I found out that positional parameters in the form of With the latest changes in this PR usage will be printed if the program was not called correctly. If an error happens in the business logic the stack is printed but not the usage. Exit code will be 1 in any case. |
|
Looks awesome! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517