Support multiple oneOf calls that are not nested

[viralanomaly]

Right now, the only way to have my request show a second, unrelated oneOf selection is to do this:

MyObject:
  allOf:
    - oneOf:
        - allOf:
           - $ref: 'RefToChoice1Option1'
           - oneOf:
              - $ref: 'RefToChoice2Option1'
              - $ref: 'RefToChoice2Option2'
        - allOf:
           - $ref: 'RefToChoice1Option2'
           - oneOf:
              - $ref: 'RefToChoice2Option1'
              - $ref: 'RefToChoice2Option2'

I would prefer to be able to do this:

MyObject:
  allOf:
    - oneOf:
       - $ref: 'RefToChoice1Option1'
       - $ref: 'RefToChoice1Option2'
    - oneOf:
       - $ref: 'RefToChoice2Option1'
       - $ref: 'RefToChoice2Option2'

[RomanHotsiy]

Could you please provide more details about your use case so I better understand what you are going to achieve.
Thanks

[viralanomaly]

Sure. I have an absolutely wretched API to document. The request has a lot of options. I'm needing to support this sort of thing:
Provide username or email
Provide bank account details object or credit card details object
(This is very much simplified from the 5 or 6 levels of choices I actually have, but it still shows the problem)

These two choices are completely independent of each other, but the only way I can get it to render correctly in redoc is with the first style of code:

MyObject:
  allOf:
    - oneOf:
        - allOf:
           - $ref: '#/components/schemas/Username'
           - oneOf:
              - $ref: '#/components/schemas/BankAccountDetails'
              - $ref: '#/components/schemas/CreditCardDetails'
        - allOf:
           - $ref: '#/components/schemas/Email'
           - oneOf:
              - $ref: '#/components/schemas/BankAccountDetails'
              - $ref: '#/components/schemas/CreditCardDetails'
    - My other properties here that aren't a choice

I expected to be able to represent this like this when I started:

MyObject:
  allOf:
    - oneOf:
        - $ref: '#/components/schemas/Username'
        - $ref: '#/components/schemas/Email'
    - oneOf:
         - $ref: '#/components/schemas/BankAccountDetails'
         - $ref: '#/components/schemas/CreditCardDetails'
    - My other properties here that aren't a choice

[RomanHotsiy]

@viralanomaly got it! Thanks for the detailed explanation.

This is rare use case and it's not so easy to fix so PR's are welcome.
Hint: I could be handled in OpenAPIParser.mergeAllOf

[viralanomaly]

I'll see if I can find time to take a look. :)

[viralanomaly]

@RomanGotsiy, I fear this may have broken some of the oneOf logic for displaying choices (or at least it's broken on the alpha 29 you referenced, even if it wasn't that change specifically). My spec renders correctly in swagger-editor and swagger-ui, so I'm optimistic that I have the syntax correct. Do you want me to write a new issue for it?

[RomanHotsiy]

@viralanomaly Yes, please!

[viralanomaly]

Here you go!

#569