Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReDoc incorrectly detects types of array fields inside object #84

Closed
RomanHotsiy opened this issue Aug 23, 2016 · 3 comments
Closed

ReDoc incorrectly detects types of array fields inside object #84

RomanHotsiy opened this issue Aug 23, 2016 · 3 comments
Assignees

Comments

@RomanHotsiy
Copy link
Member

"Def1": {
  "properties": {
    "prop1": {
      "type": "array",
       "items": {
         "$ref": "#/definitions/Def2"
       }
     }
  }
},
"Def2": {
  "properties": {
     ....
  }
}

prop1 is detected as object

Reported by @fcaprilli in #83

@RomanHotsiy
Copy link
Member Author

@fcaprilli the issue is resolved and new release is published to the CDN.

Let me know if it works for you.

@fcaprilli
Copy link

Hey Roman:

Yes, the arrays properly expand now. Thanks!

I am still seeing Warning errors at the top of the page:

No "type" specified at "#/definitions/Summaries". Automatically detected: "object"
No "type" specified at "#/definitions/Status". Automatically detected: "object"
No "type" specified at "#/definitions/WirelineCustomerSummary". Automatically detected: "object"
No "type" specified at "#/definitions/NameInfo". Automatically detected: "object"
No "type" specified at "#/definitions/WirelineAccountSummary". Automatically detected: "object"
No "type" specified at "#/definitions/PaymentMethodInfo". Automatically detected: "object"
No "type" specified at "#/definitions/BillCycleInfo". Automatically detected: "object"
No "type" specified at "#/definitions/WirelessAccountSummary". Automatically detected: "object"
No "type" specified at "#/definitions/NameInfo". Automatically detected: "object"
No "type" specified at "#/definitions/StandbyInfo". Automatically detected: "object"
No "type" specified at "#/definitions/Status". Automatically detected: "object"

Also, on the 3rd pane, there is no response sample shown:

[cid:image001.png@01D202D1.201BD100]

And in the left pane, the description is truncated:

[cid:image002.png@01D202D1.201BD100]

From: Roman Hotsiy [mailto:notifications@github.com]
Sent: August 30, 2016 01:49 PM
To: Rebilly/ReDoc ReDoc@noreply.github.com
Cc: Fred Caprilli Fred.Caprilli@telus.com; Mention mention@noreply.github.com
Subject: Re: [Rebilly/ReDoc] ReDoc incorrectly detects types of array fields inside object (#84)

@fcaprillihttps://github.com/fcaprilli the issue is resolved and new release is published to the CDN.

Let me know if it works for you.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/84#issuecomment-243522233, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUMatE7M9KmS35bDHSMcKCWhzGsi8uLzks5qlG0mgaJpZM4Jq3eE.

@RomanHotsiy
Copy link
Member Author

@fcaprilli I can't see attached images.

regarding warnings you see you have two option:

  1. add type: object to each definition you get warnings for
  2. add suppress-warnings attribute to <redoc> tag:
<redoc spec-url="..." suppress-warnings></redoc>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants