Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove querystring from exposed URL #895

Merged
merged 1 commit into from
May 12, 2019
Merged

Remove querystring from exposed URL #895

merged 1 commit into from
May 12, 2019

Conversation

antograssiot
Copy link
Contributor

If ReDoc is initiated on a page containing query strings in the URL, the generated URL is misbehaving as shown on the following image

Capture d’écran 2019-04-19 à 15 32 02

Live example at https://demo.api-platform.com/?ui=re_doc&spec_version=3

After this change the exposed URL would be https://demo.api-platform.com/books as expected

@antograssiot antograssiot mentioned this pull request Apr 19, 2019
Closed
@coveralls
Copy link

coveralls commented Apr 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 81.769% when pulling 186e7b9 on antograssiot:filter-querystring into 5dd5d6d on Rebilly:master.

RomanHotsiy
RomanHotsiy requested changes May 6, 2019
View reviewed changes
Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like origin doesn't include pathname so you're removing querystring and pathname here. Could you update to remove querystring only?

@antograssiot antograssiot force-pushed the filter-querystring branch from ffb186d to 186e7b9 Compare May 7, 2019 05:20
@antograssiot
Copy link
Contributor Author

updated as requested I think @RomanGotsiy

@RomanHotsiy RomanHotsiy merged commit 64453ff into Redocly:master May 12, 2019
@RomanHotsiy
Copy link
Member

Thanks!

@antograssiot antograssiot deleted the filter-querystring branch May 12, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanHotsiy RomanHotsiy RomanHotsiy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antograssiot @coveralls @RomanHotsiy