Android minor fixes #285
Merged
Android minor fixes #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoalaSat
commented
Oct 14, 2022
| export type { Limit } from './Limit.model'; | ||
| export type { Maker } from './Maker.model'; | ||
| export { defaultMaker } from './Maker.model'; | ||
| export type { Order } from './Order.model'; |
There was a problem hiding this comment.
These was being displayed as warnings on the compiler logs
KoalaSat
commented
Oct 14, 2022
| } catch { | ||
| await torClient.reset(); | ||
| return sendTorStatus(); | ||
| } |
There was a problem hiding this comment.
First attempt to try to automatically recover from a dead daemon
KoalaSat
commented
Oct 14, 2022
| this.props.setAppState({ token }); | ||
| this.setState({ token, loadingRobot: false }); | ||
| this.setState({ token }); | ||
| this.getGeneratedUser(token); |
There was a problem hiding this comment.
this will generate a new sessionid, turns out I had my sessionid on Android Studio outdated and this fix worked
KoalaSat
commented
Oct 14, 2022
| @@ -245,6 +245,7 @@ class UserGenPage extends Component { | |||
| width: `${201 * fontSizeFactor}px`, | |||
| }} | |||
| tooltip={t('This is your trading avatar')} | |||
| tooltipPosition='up' | |||
There was a problem hiding this comment.
This one is causing the view on Android to overflow when you tap on the avatar 😄
There was a problem hiding this comment.
Good catch 😄 . It happened to me and I did not know why!
|
It looks good! Thanks for these fixes. Ready to be merged 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes some minor errors on the Android app.
Checklist before merging
cd frontend; npm run format. If it's a mobile app feature I rancd mobile; npm run format.