Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to pep8 rules #295

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conform to pep8 rules #295

merged 2 commits into from
Oct 20, 2022

Conversation

redphix
Copy link
Contributor

@redphix redphix commented Oct 20, 2022

What does this PR do?

Conforms to pep8 standards for all py files

@redphix redphix marked this pull request as ready for review October 20, 2022 15:16
@redphix
Copy link
Contributor Author

redphix commented Oct 20, 2022

ah nice I missed a few and the linter was able to catch it! Useful already!

@redphix
Copy link
Contributor Author

redphix commented Oct 20, 2022

There are still 5 errors, I want you to check them and see that fixing them wont cause some side effect. I am not comfortable changing these ones, as I don't understand them fully -- for example, there could be a reason why you might import something but not really use it in there, etc.

Also, although I have made changes carefully, it would still be good if you review them with a sharp eye as well -- better to be double sure.

@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Oct 20, 2022

The 5 unused imports left as errors are fair: I do not think these will break anything.

I will build a coordinator image based on this PR and give it a test run to confirm everything still working.

@Reckless-Satoshi
Copy link
Collaborator

I will build a coordinator image based on this PR and give it a test run to confirm everything still working.

@redphix
Nothing in the trade pipeline, celery tasks, or other backend processes seems broken. Still many things I can't test quickly. But it looks okay to me to be merged. Let's also fix those 5 errors left, then we can run further tests on the Testnet platform in case something escaped.

@Reckless-Satoshi Reckless-Satoshi merged commit 4d5c602 into RoboSats:main Oct 20, 2022
@redphix redphix deleted the style/pep8 branch October 21, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants