Add pre-commit-config #298
Conversation
| @@ -734,7 +734,11 @@ def update_invoice(cls, order, user, invoice): | |||
| if not order.taker_bond: | |||
| return False, {"bad_request": "Wait for your order to be taken."} | |||
| if ( | |||
| not ( order.taker_bond.status == order.maker_bond.status == LNPayment.Status.LOCKED) | |||
There was a problem hiding this comment.
Fixed the changes introduced by that 'annoy black' PR in this file
.pre-commit-config.yaml
Outdated
| - merge-commit | ||
| language: system | ||
| files: ^frontend/ | ||
| types: [javascript, jsx, ts, tsx, css, markdown, json] # uses https://github.com/pre-commit/identify |
There was a problem hiding this comment.
First time using pre-commit pip package. This is really powerful!
It seems it is not running npm run format when I add some style mistake on the /frontend
prettier-frontend....................................(no files to check) SkippedThere was a problem hiding this comment.
ahh, was a mistake with the types key. Changed it to types_or
|
Awesome, merging! 🚀 We did not have a rewarded task created for this PR beforehand. But it's actually pretty important and will make or life easier. Let's add a few sats to the positive Karma, please submit an invoice for 100K Sats from a proxy wallet with a long expiration time. |
|
@Reckless-Satoshi Thank you ❤️ 🤗 |
fbe7afbb121b363e7f12fb2ed445116216698ef1a4dfb1be4e54c1f81cf9e5b4 |
What does this PR do?
Adds a pre-commit config to run linters/formaters before committing
Steps every contributor must follow before working:
pip install pre-commitpre-commit installChecklist before merging
cd frontend; npm run format. If it's a mobile app feature I rancd mobile; npm run format.