Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit to CONTRIBUTING.md #305

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

redphix
Copy link
Contributor

@redphix redphix commented Oct 25, 2022

What does this PR do?

Checklist before merging

  • If it's a frontend feature, I have ran prettier cd frontend; npm run format. If it's a mobile app feature I ran cd mobile; npm run format.

@redphix
Copy link
Contributor Author

redphix commented Oct 25, 2022

Also changed the PR template, but not sure if we want it there, because by the time the contributor sees the checklist and hasn't yet installed pre-commit, then it's too late. They will have to install and run the pre-commit hook once manually. Speaking of, will have to run the hooks once so that we have a "clean" state of the repo- pre-commit run --all-files. There are a bunch of whitespace/newlines issues all over the place.

@Reckless-Satoshi
Copy link
Collaborator

Looks great!

@Reckless-Satoshi Reckless-Satoshi merged commit f21a15b into RoboSats:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants