Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android fixed turtle mode #323

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

KoalaSat
Copy link
Member

@KoalaSat KoalaSat commented Nov 14, 2022

What does this PR do?

Always forces turtle mode on Android app.
Posted chat messages are displayed on the same request.

Checklist before merging

  • Make sure you have installed and initialized pre-commit. pip install pre-commit and pre-commit install

@KoalaSat KoalaSat marked this pull request as ready for review November 14, 2022 13:22
@Reckless-Satoshi
Copy link
Collaborator

Hey @KoalaSat . This PR looks good! Merging as is.

Have you been able to test it? Last time I tried the turtle mode was not receiving/sending messages. I was not able to look into the Android app logs, but given that the "send" button was disabled possibly the peer_pubkey was not received.

@Reckless-Satoshi Reckless-Satoshi merged commit 9f66221 into RoboSats:main Nov 15, 2022
@KoalaSat
Copy link
Member Author

Hey @KoalaSat . This PR looks good! Merging as is.

Have you been able to test it? Last time I tried the turtle mode was not receiving/sending messages. I was not able to look into the Android app logs, but given that the "send" button was disabled possibly the peer_pubkey was not received.

Yes I tested it in both web and Android and it works, but truth is that I didn't test starting with an empty chat, do you think the peerpud key problem would be related to that?

@KoalaSat KoalaSat deleted the android-fixed-turtle-mode branch November 24, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants