Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export chat android #324

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

KoalaSat
Copy link
Member

What does this PR do?

Fixes the Export chat button, when clicked on Android, it copies the content to the clipboard instead of generating a file.

Checklist before merging

  • Make sure you have installed and initialized pre-commit. pip install pre-commit and pre-commit install

@KoalaSat KoalaSat marked this pull request as ready for review November 16, 2022 14:39
@Reckless-Satoshi
Copy link
Collaborator

Hey @KoalaSat , this is a really neat solution for the export in Android. 🚀

It might not be clear for the user that after clicking the export button nothing happens the log is now on the clipboard. What do you think about adding a Tooltip with "Copied!" identical to the ones we use for copying to clipboard tokens and invoices?

@KoalaSat
Copy link
Member Author

KoalaSat commented Nov 16, 2022

Yeah right, I just didn't noticed because on the lastest versions of android the system notifies you what goes to the clipboard

@Reckless-Satoshi
Copy link
Collaborator

Merging as is. I will add the tooltip and ship the full app as is in a new release.

@Reckless-Satoshi Reckless-Satoshi merged commit 7c32937 into RoboSats:main Nov 17, 2022
@KoalaSat KoalaSat deleted the fix-export-chat-android branch November 24, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants