Deprecate old routing budget pipeline #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the advanced options for buyer payouts was implemented, a new feature that allowed users to select the routing budget was implemented. This allowed users to receive in some previously incompatible wallets such as Muun. The change made any existing client incompatible, therefore, both pipelines have been supported by the coordinator until now. With this PR, the old routing budget mechanics are no longer supported.
TLDR; Clients older than 0.3.1 are 'incompatible'. These only will submit buyer payout requests with a routing budget of 0ppm!
Checklist before merging
pip install pre-commitandpre-commit install