Frontend code for Image Builder.
- Website: https://www.osbuild.org
- Bug Tracker: https://github.com/osbuild/image-builder-frontend/issues
- Discussions: https://github.com/orgs/osbuild/discussions
- Matrix: #image-builder on fedoraproject.org
- We want to use the latest and greatest web technologies.
- We want to expose all the options and customizations possible, even if not all are visible by default.
- The default path should be ‘short(est)’ clickpath, which should be determined in a data-driven way.
- This is an Insights application, so it abides by some rules and standards of Insights.
To develop the frontend you can use a proxy to run image-builder-frontend locally against the chrome and backend at console.redhat.com.
Working against the production environment is preferred, as any work can be released without worrying if a feature from stage has been released yet.
Make sure you have npm@10 and node 18+ installed. If you need multiple versions of nodejs check out nvm.
-
run
npm ci
-
run
npm run start
, select prod environment and choose beta or stable. -
redirect
prod.foo.redhat.com
to localhost, if this has not been done already.
echo "127.0.0.1 prod.foo.redhat.com" >> /etc/hosts
- open browser at
https://prod.foo.redhat.com:1337/beta/insights/image-builder
-
run
npm ci
-
run
npm run start
, select stage environment and choose beta or stable. -
redirect
stage.foo.redhat.com
to localhost, if this has not been done already.
echo "127.0.0.1 stage.foo.redhat.com" >> /etc/hosts
- open browser at
https://stage.foo.redhat.com:1337/beta/insights/image-builder
-
Clone the insights proxy: https://github.com/RedHatInsights/insights-proxy
-
Setting up the proxy
Choose a runner (podman or docker), and point the SPANDX_CONFIG variable to
profile/local-frontend.js
included in image-builder-frontend.sudo insights-proxy/scripts/patch-etc-hosts.sh export RUNNER="podman" export SPANDX_CONFIG=$PATH_TO/image-builder-frontend/profiles/local-frontend.js sudo -E insights-proxy/scripts/run.sh
-
Starting up image-builder-frontend
In the image-builder-frontend checkout directory
npm install npm start
The UI should be running on https://prod.foo.redhat.com:1337/beta/insights/image-builder/landing. Note that this requires you to have access to either production or stage (plus VPN and proxy config) of insights.
API slice definitions are programmatically generated using the @rtk-query/codegen-openapi package.
OpenAPI schema for the endpoints are stored in /api/schema
. Their
corresponding configuration files are stored in /api/config
. Each endpoint
has a corresponding empty API slice and generated API slice which are stored in
/src/store
.
For a hypothetical API called foobar
-
Download the foobar API OpenAPI json or yaml representation under
api/schema/foobar.json
-
Create a new "empty" API file under
src/store/emptyFoobarApi.ts
that has following content:
import { createApi, fetchBaseQuery } from '@reduxjs/toolkit/query/react';
import { FOOBAR_API } from '../constants';
// initialize an empty api service that we'll inject endpoints into later as needed
export const emptyFoobarApi = createApi({
reducerPath: 'foobarApi',
baseQuery: fetchBaseQuery({ baseUrl: window.location.origin + FOO_BAR }),
endpoints: () => ({}),
});
- Declare new constant
FOOBAR_API
with the API url insrc/constants.ts
export const FOOBAR_API = 'api/foobar/v1'
- Create the config file for code generation in
api/config/foobar.ts
containing:
import type { ConfigFile } from '@rtk-query/codegen-openapi';
const config: ConfigFile = {
schemaFile: '../schema/foobar.json',
apiFile: '../../src/store/emptyFoobarApi.ts',
apiImport: 'emptyEdgeApi',
outputFile: '../../src/store/foobarApi.ts',
exportName: 'foobarApi',
hooks: true,
filterEndpoints: ['getFoo', 'getBar', 'getFoobar'],
};
- Update the
api.sh
script by adding a new line for npx to generate the code:
npx @rtk-query/codegen-openapi ./api/config/foobar.ts &
- Update the
.eslintignore
file by adding a new line for the generated code:
foobarApi.ts
- run api generation
npm run api
And voilà!
To add a new endpoint, simply update the api/config/foobar.ts
file with new
endpoints in the filterEndpoints
table.
Your user needs to have the corresponding rights, do the same as this MR in internal gitlab https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/79225 you can ask on the slack channel https://redhat-internal.slack.com/archives/C023YSA47A4 for a merge if your MR stays unchecked for a little while.
Then connect to the following platforms:
Once you have a toggle to work with, on the frontend code there's just need to
import the useFlag
hook and to use it. You can get some inspiration from
existing flags:
Flags can be mocked for the unit tests to access some feature. Checkout: https://github.com/osbuild/image-builder-frontend/blob/9a464e416bc3769cfc8e23b62f1dd410eb0e0455/src/test/Components/CreateImageWizard/CreateImageWizard.test.tsx#L49
If the two possible code path accessible via the toggles are defined in the code base, then it's good practice to test the two of them. If not, only test what's actually owned by the frontend project.
Unleash toggles are expected to live for a limited amount of time, documentation specify 40 days for a release, we should keep that in mind for each toggle we're planning on using.
To develop both the frontend and the backend you can again use the proxy to run both the frontend and backend locally against the chrome at cloud.redhat.com. For instructions see the osbuild-getting-started project.
The following scripts are used to build the frontend with Webpack and install it into the Cockpit directories. These scripts streamline the development process by automating build and installation steps.
Runs Webpack with the specified configuration (cockpit/webpack.config.ts) to build the frontend assets. Use this command whenever you need to compile the latest changes in your frontend code.
Creates the necessary directory in the user's local Cockpit share (~/.local/share/cockpit/). Creates a symbolic link (image-builder-frontend) pointing to the built frontend assets (cockpit/public). Use this command after building the frontend to install it locally for development purposes. The symbolic link allows Cockpit to serve the frontend assets from your local development environment, making it easier to test changes in real-time without deploying to a remote server.
make devel-install
make build
To uninstall and remove the symbolic link, run the following command:
make devel-uninstall
For convenience, you can run the following to combine all three steps:
make cockpit/all
Directory | Description |
---|---|
/api |
API schema and config files |
/config |
webpack configuration |
/devel |
tools for local development |
/src |
source code |
/src/Components |
source code split by individual components |
/src/test |
test utilities |
/src/test/mocks |
mock handlers and server config for MSW |
/src/store |
Redux store |
This project uses eslint's recommended styling guidelines. These rules can be found here: https://eslint.org/docs/rules/
To run the linter, use:
npm run lint
Any errors that can be fixed automatically, can be corrected by running:
npm run lint --fix
All the linting rules and configuration of eslint can be found in .eslintrc.yml
.
There are also additional rules added to enforce code style. Those being:
import/order
-> enforces the order in import statements and separates them into groups based on their typeprefer-const
-> enforces use ofconst
declaration for variables that are never reassignedno-console
-> throws an error for any calls ofconsole
methods leftover after debugging
This project is tested using the Vitest framework, React Testing Library, and the Mock Service Worker library.
All UI contributions must also include a new test or update an existing test in order to maintain code coverage.
To run the unit tests, the linter, and the code coverage check run:
npm run test
These tests will also be run in our CI when a PR is opened.
Note that testing-library
DOM printout is currently disabled for all tests by the following configuration in src/test/setup.ts
:
configure({
getElementError: (message: string) => {
const error = new Error(message);
error.name = 'TestingLibraryElementError';
error.stack = '';
return error;
},
});
If you'd like to see the stack printed out you can either temporarily disable the configuration or generate a Testing Playground link by adding screen.logTestingPlaygroundURL()
to your test.
If you want to develop in environment with mocked data, run the command npm run stage-beta:msw
.
In a case you're seeing Error: [MSW] Failed to register the Service Worker
in console, you might also need to configure SSL certification on your computer.
In order to do this install mkcert
After the installation, go to the /node_modules/.cache/webpack-dev-server
folder and run following commands:
mkcert -install
to create a new certificate authority on your machinemkcert prod.foo.redhat.com
to create the actual signed certificate
Follow these steps to find and paste the certification file into the 'Keychain Access' application:
-
Open the 'Keychain Access' application.
-
Select 'login' on the left side.
-
Navigate to the 'Certificates' tab.
-
Drag the certification file (located at /image-builder-frontend/node_modules/.cache/webpack-dev-server/server.pem) to the certification list.
-
Double-click on the added certificate (localhost certificate) to open the localhost window.
-
Open the 'Trust' dropdown menu.
-
Set all options to 'Always Trust'.
-
Close the localhost screen.
-
Run
npm run stage-beta:msw
and open the Firefox browser to verify that it is working as expected.