fix(RecsListTable): Reset filters button behavior update #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed tests that were failing due to the changes
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 76.58% 76.44% -0.15%
==========================================
Files 27 27
Lines 897 900 +3
Branches 322 324 +2
==========================================
+ Hits 687 688 +1
- Misses 210 212 +2
Continue to review full report at Codecov.
|
gkarat
requested changes
Mar 17, 2022
Fewwy
force-pushed
the
ccxdev-7614-reset-filters-recslist
branch
5 times, most recently
from
94218a9 to
45aa7eb
Compare
Repaired 2 tests that were broken
Fewwy
force-pushed
the
ccxdev-7614-reset-filters-recslist
branch
from
45aa7eb to
559cad2
Compare
gkarat
reviewed
Mar 21, 2022
gkarat
approved these changes
Mar 21, 2022
gkarat
pushed a commit
that referenced
this pull request
Mar 21, 2022
|
🎉 This PR is included in version 1.0.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
gkarat
added a commit
that referenced
this pull request
Mar 24, 2022
* fix(RecsListTable): Reset filters button behavior update (#183) The recommendations list page Reset filters button change: the button is always available; if the button is clicked with the default filters, then the data are re-fetched; if the button is clicked with extra filters applied, it sets them to the default set. * fix(ClusterListTable): Updated the reset filters behavior (#184) The clusters list page Reset filters button change: the button is always available; if the button is clicked with the default filters, then the data are re-fetched; if the button is clicked with extra filters applied, it sets them to the default set. * chore(release): 1.0.14 [skip ci] ## [1.0.14](v1.0.13...v1.0.14) (2022-03-21) ### Bug Fixes * **ClusterListTable:** Updated the reset filters behavior ([#184](#184)) ([e184d33](e184d33)) * **RecsListTable:** Reset filters button behavior update ([#183](#183)) ([2287020](2287020)) * fix(AffectedClustersTable): rename reset filters button (#186) * chore(release): 1.0.15 [skip ci] ## [1.0.15](v1.0.14...v1.0.15) (2022-03-21) ### Bug Fixes * **AffectedClustersTable:** rename reset filters button ([#186](#186)) ([c5111cc](c5111cc)) * fix(disable modal): bug with multiple selections (#187) This fixes a bug: if user selects multiple clusters, unchecks "Disable recommendation for selected clusters" flag, then the recommendation will only be disabled for selected clusters. This is incorrect, and the recommendation should be disabled for all clusters in this scenario. * chore(release): 1.0.16 [skip ci] ## [1.0.16](v1.0.15...v1.0.16) (2022-03-23) ### Bug Fixes * **disable modal:** bug with multiple selections ([#187](#187)) ([659af06](659af06)) * chore(deps): bump axios from 0.26.0 to 0.26.1 (#172) Bumps [axios](https://github.com/axios/axios) from 0.26.0 to 0.26.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.26.0...v0.26.1) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(tables): revert the time-based refresh feature This reverts the feature of data time-based refresh (was set to 20 seconds) in the clusters list and recommendations list tables. * chore: leave FIXMEs at the improper title change * chore(release): 1.0.17 [skip ci] ## [1.0.17](v1.0.16...v1.0.17) (2022-03-24) ### Bug Fixes * **tables:** revert the time-based refresh feature ([5961ef7](5961ef7)) Co-authored-by: Fewwy <62722417+Fewwy@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the task CCXDEV-7614 I updated the "Reset filters" behavior