Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SingleClusterPage): New dropdown and action button #192

Merged
merged 4 commits into from
Mar 28, 2022

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented Mar 24, 2022

1)Added a dropdown to the Cluster Header component
2)Added a dropdown item
3)Set up the redirect to the OCM
screenshots are in the Jira card

@Fewwy Fewwy self-assigned this Mar 24, 2022
@Fewwy Fewwy added the enhancement New feature or request label Mar 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #192 (792a991) into master (5f263ce) will decrease coverage by 0.26%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   76.19%   75.92%   -0.27%     
==========================================
  Files          27       27              
  Lines         903      914      +11     
  Branches      327      328       +1     
==========================================
+ Hits          688      694       +6     
- Misses        215      220       +5     
Impacted Files Coverage Δ
src/Components/ClusterHeader/ClusterHeader.js 80.76% <54.54%> (-19.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93f0a4...792a991. Read the comment docs.

src/Components/ClusterHeader/ClusterHeader.js Outdated Show resolved Hide resolved
src/Components/ClusterHeader/ClusterHeader.js Outdated Show resolved Hide resolved
src/Components/ClusterHeader/ClusterHeader.js Outdated Show resolved Hide resolved
@gkarat
Copy link
Collaborator

gkarat commented Mar 25, 2022

Can you please also add tests to this feature? :-)

Fewwy added 2 commits March 25, 2022 16:04
Added missing translation
Used assign instead of replace
@gkarat gkarat self-requested a review March 28, 2022 14:42
Copy link
Collaborator

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, new buttoonnnn aproachinn

@gkarat gkarat merged commit 2b73580 into RedHatInsights:master Mar 28, 2022
gkarat pushed a commit that referenced this pull request Mar 28, 2022
# [1.2.0](v1.1.0...v1.2.0) (2022-03-28)

### Features

* **Single cluster page:** View in clusters button ([#192](#192)) ([2b73580](2b73580))
@gkarat
Copy link
Collaborator

gkarat commented Mar 28, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants