Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AffectedClustersTable): set default sorting to last seen #202

Merged

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented Mar 30, 2022

Set default sorting to last seen
Updated 1 failing test
image

@Fewwy Fewwy self-assigned this Mar 30, 2022
@Fewwy Fewwy added the enhancement New feature or request label Mar 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #202 (b2ad6a3) into master (d75f44c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files          27       27           
  Lines         976      976           
  Branches      362      362           
=======================================
  Hits          747      747           
  Misses        229      229           
Impacted Files Coverage Δ
src/Services/Filters.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75f44c...b2ad6a3. Read the comment docs.

@gkarat gkarat merged commit 1b04ece into RedHatInsights:master Mar 30, 2022
@gkarat gkarat self-requested a review March 30, 2022 11:08
Copy link
Collaborator

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

gkarat pushed a commit that referenced this pull request Mar 30, 2022
## [1.3.2](v1.3.1...v1.3.2) (2022-03-30)

### Bug Fixes

* **Affected clusters table:** set default sorting by last seen ([#202](#202)) ([1b04ece](1b04ece))
@gkarat
Copy link
Collaborator

gkarat commented Mar 30, 2022

🎉 This PR is included in version 1.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants