fix(ClusterRules): Open rows memorization #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it stays expanded
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 83.00% 80.73% -2.28%
==========================================
Files 24 24
Lines 924 929 +5
Branches 331 336 +5
==========================================
- Hits 767 750 -17
- Misses 157 179 +22
Continue to review full report at Codecov.
|
|
There is no "enh" commit type. Refer to https://github.com/angular/angular/blob/main/CONTRIBUTING.md#type and https://github.com/semantic-release/semantic-release#commit-message-format and fix this. |
gkarat
reviewed
May 3, 2022
Fewwy
changed the title
There are some bugs still present
Fewwy
force-pushed
the
ccx7900-cluster-list-sorting
branch
from
6d6c4f7 to
167df42
Compare
Rewrote the test
Fewwy
force-pushed
the
ccx7900-cluster-list-sorting
branch
from
167df42 to
80b24ee
Compare
gkarat
reviewed
May 5, 2022
Implemented set
gkarat
approved these changes
May 6, 2022
gkarat
pushed a commit
that referenced
this pull request
May 9, 2022
## [1.3.10](v1.3.9...v1.3.10) (2022-05-09) ### Bug Fixes * **ClusterRules:** Open rows memorization ([#251](#251)) ([83f754e](83f754e))
|
🎉 This PR is included in version 1.3.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/CCXDEV-7900.
Recording the opened rows for the single cluster page
Fixed the test
The expand collapse behavior:
1)When the user opens the page for the first time - the first row is expanded
2)If he clicks sort after that, only the rows that were expanded will stay that way
if he expands several different rows\all rows before that -> only these rows will stay expanded