fix(Cluster rules table): display table rows only when filtering is completed #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 83.22% 83.27% +0.05%
==========================================
Files 24 24
Lines 924 927 +3
Branches 331 331
==========================================
+ Hits 769 772 +3
Misses 155 155
Continue to review full report at Codecov.
|
gkarat
changed the title
gkarat
force-pushed
the
fix-check-row-counts-cluster-rules
branch
from
471ecae to
474804a
Compare
gkarat
pushed a commit
that referenced
this pull request
May 9, 2022
## [1.3.12](v1.3.11...v1.3.12) (2022-05-09) ### Bug Fixes * **Cluster rules table:** display table rows only when filerting is complete ([#261](#261)) ([8016533](8016533))
|
🎉 This PR is included in version 1.3.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was discovered when the cypress rows counting test was failing (for a manual test, the bug is not visible, however, automated tests are able to identify them since they manipulate with interface way faster than users).
This makes the table show rows only when the data filtering and sorting are complete.