Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(App): babel transformation for the react-core modules #279

Merged
merged 5 commits into from
May 27, 2022

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented May 16, 2022

Updated the react-core imports
Size became smaller (13.02 -> 12.98)
I think that we need to reduce the bundle size overall, it's too big :(

image

@Fewwy Fewwy added the enhancement New feature or request label May 16, 2022
@Fewwy Fewwy self-assigned this May 16, 2022
@Fewwy Fewwy requested a review from gkarat May 18, 2022 10:17
@Fewwy Fewwy force-pushed the ccxdev-8096-imports-transform branch from 8b28c9a to 1d4593b Compare May 18, 2022 10:26
Copy link
Collaborator

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey I've just skimmed through the remaining imports: looks like you haven't included all of the component imports. I am also curious if you can transform imports for layout?

image

config/dev.webpack.config.js Outdated Show resolved Hide resolved
babel.config.js Outdated Show resolved Hide resolved
babel.config.js Outdated Show resolved Hide resolved
src/Components/Recommendation/Recommendation.js Outdated Show resolved Hide resolved
@Fewwy Fewwy requested a review from gkarat May 26, 2022 07:49
@Fewwy Fewwy force-pushed the ccxdev-8096-imports-transform branch 2 times, most recently from 49de61c to b35e3b1 Compare May 27, 2022 10:07
@Fewwy Fewwy force-pushed the ccxdev-8096-imports-transform branch from b35e3b1 to 8593afb Compare May 27, 2022 10:28
@Fewwy Fewwy merged commit f04ac70 into RedHatInsights:master May 27, 2022
gkarat pushed a commit that referenced this pull request May 27, 2022
## [1.4.1](v1.4.0...v1.4.1) (2022-05-27)

### Bug Fixes

* **App:** babel transformation for the react-core modules ([#279](#279)) ([f04ac70](f04ac70))
@gkarat
Copy link
Collaborator

gkarat commented May 27, 2022

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat
Copy link
Collaborator

gkarat commented May 30, 2022

Fixes #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants