Refactor empty state handling across tables; implement tests #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
changed the title
|
@RedHatInsights/team-interact, @ikerreyes, please take a look 👋🏼 |
ikerreyes
reviewed
Jun 3, 2022
src/Components/AffectedClustersTable/AffectedClustersTable.spec.ct.js
Outdated
Show resolved
Hide resolved
src/Components/AffectedClustersTable/AffectedClustersTable.spec.ct.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 85.65% 85.16% -0.50%
==========================================
Files 24 24
Lines 962 984 +22
Branches 351 359 +8
==========================================
+ Hits 824 838 +14
- Misses 138 146 +8
Continue to review full report at Codecov.
|
gkarat
force-pushed
the
ccxdev-8242-enhance-empty-state-test
branch
from
e665fa8 to
5c983e4
Compare
gkarat
pushed a commit
that referenced
this pull request
Jun 7, 2022
## [1.4.4](v1.4.3...v1.4.4) (2022-06-07) ### Bug Fixes * **Tables:** unify empty state handling across tables; implement tests ([#302](#302)) ([c59821a](c59821a))
|
🎉 This PR is included in version 1.4.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://issues.redhat.com/browse/CCXDEV-8280, https://issues.redhat.com/browse/CCXDEV-8242
Mainly refactors how table components are handling empty states. Also adds tests to check that the empty state titles, messages, and icons are rendered correctly.
Some illustrations: