Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OCP Advisor): changed N/A to not available #346

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented Jul 11, 2022

No description provided.

Copy link
Collaborator

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, looks OK, but we have a redundant

notAvailable: {
: can we leave only one message descriptor that we will use across the app? so that have either only 'nA' message or only 'notAvailable'? there should be no places in app where 'N/A' will appear

@gkarat gkarat enabled auto-merge (squash) July 11, 2022 08:42
@codecov-commenter
Copy link

Codecov Report

Merging #346 (d761af4) into master (4fcc7e8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   82.51%   82.51%           
=======================================
  Files          25       25           
  Lines        1127     1127           
  Branches      431      431           
=======================================
  Hits          930      930           
  Misses        197      197           
Impacted Files Coverage Δ
...nts/AffectedClustersTable/AffectedClustersTable.js 94.77% <100.00%> (ø)
.../Components/ClustersListTable/ClustersListTable.js 83.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcc7e8...d761af4. Read the comment docs.

@gkarat gkarat merged commit e89a6dd into RedHatInsights:master Jul 11, 2022
gkarat pushed a commit that referenced this pull request Jul 11, 2022
## [1.5.1](v1.5.0...v1.5.1) (2022-07-11)

### Bug Fixes

* Change all "N/A" to "Not available" ([#346](#346)) ([e89a6dd](e89a6dd))
@gkarat
Copy link
Collaborator

gkarat commented Jul 11, 2022

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants