feat(ClusterRules): Add impacted to single Cluster page #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerreyes
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Looks good to me.
Just one note, the field is declared as optional in the API spec (https://github.com/RedHatInsights/insights-results-smart-proxy/blob/master/server/api/v2/openapi.json#L1229). I think it is an error, as it does not make sense to have a rule hit without a timestamp, but if it is possible, we should enhance the test to account for that.
I will try to clarify that.
|
After discussing, it might be the case for some old archives, so it might be worth to test for that scenario as well |
gkarat
reviewed
Jul 20, 2022
refactored the code
gkarat
approved these changes
Jul 21, 2022
gkarat
pushed a commit
that referenced
this pull request
Jul 21, 2022
# [1.6.0](v1.5.5...v1.6.0) (2022-07-21) ### Features * **Single cluster page:** Add a new column Impacted ([#366](#366)) ([2362508](2362508))
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
gkarat
pushed a commit
that referenced
this pull request
Aug 17, 2022
gkarat
pushed a commit
that referenced
this pull request
Aug 17, 2022
# [1.6.0](v1.5.5...v1.6.0) (2022-07-21) ### Features * **Single cluster page:** Add a new column Impacted ([#366](#366)) ([2362508](2362508))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the impacted column component + state when the impacted data is not available + tests