Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPADVISOR-62] Reset page number on filter #477

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

johnsonm325
Copy link
Contributor

On affected clusters and clusters list tables, if you change per page or reset/apply filters, you will stay on the same page. Pages should be reset to 1 if you change the per page count or apply or remove a filter. This PR fixes those issues.

On affected clusters and clusters list tables, if you change per page or reset/apply filters, you will stay on the same page. Pages should be reset to 1 if you change the per page count or apply or remove a filter. This PR fixes those issues.
@johnsonm325 johnsonm325 requested a review from a team November 28, 2022 20:40
@codecov-commenter
Copy link

Codecov Report

Base: 86.91% // Head: 86.90% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (23f5b05) compared to base (5dcffd0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   86.91%   86.90%   -0.02%     
==========================================
  Files          25       25              
  Lines        1162     1161       -1     
  Branches      445      444       -1     
==========================================
- Hits         1010     1009       -1     
  Misses        152      152              
Impacted Files Coverage Δ
...nts/AffectedClustersTable/AffectedClustersTable.js 95.68% <100.00%> (ø)
.../Components/ClustersListTable/ClustersListTable.js 88.23% <100.00%> (ø)
src/Services/Filters.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run it locally, but I see that at least for the Clusters list page, the sorting is reset after the click on Reset filters. I think this is not intended because you say only the current page should be reset to 1.

@johnsonm325
Copy link
Contributor Author

I tried to run it locally, but I see that at least for the Clusters list page, the sorting is reset after the click on Reset filters. I think this is not intended because you say only the current page should be reset to 1.

I was not able to reproduce this.

@gkarat gkarat merged commit 7315589 into RedHatInsights:master Nov 29, 2022
@gkarat
Copy link
Collaborator

gkarat commented Nov 29, 2022

Tried again, not sure what was the issue, but now I can't reproduce that too (probably was looking at the wrong env). LGTM 👍🏼

gkarat pushed a commit that referenced this pull request Nov 29, 2022
## [1.8.4](v1.8.3...v1.8.4) (2022-11-29)

### Bug Fixes

* **Tables:** Reset page number on filter ([#477](#477)) ([7315589](7315589))
@gkarat
Copy link
Collaborator

gkarat commented Nov 29, 2022

🎉 This PR is included in version 1.8.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants