-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCPADVISOR-62] Reset page number on filter #477
Conversation
On affected clusters and clusters list tables, if you change per page or reset/apply filters, you will stay on the same page. Pages should be reset to 1 if you change the per page count or apply or remove a filter. This PR fixes those issues.
Codecov ReportBase: 86.91% // Head: 86.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
==========================================
- Coverage 86.91% 86.90% -0.02%
==========================================
Files 25 25
Lines 1162 1161 -1
Branches 445 444 -1
==========================================
- Hits 1010 1009 -1
Misses 152 152
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run it locally, but I see that at least for the Clusters list page, the sorting is reset after the click on Reset filters. I think this is not intended because you say only the current page should be reset to 1.
I was not able to reproduce this. |
Tried again, not sure what was the issue, but now I can't reproduce that too (probably was looking at the wrong env). LGTM 👍🏼 |
## [1.8.4](v1.8.3...v1.8.4) (2022-11-29) ### Bug Fixes * **Tables:** Reset page number on filter ([#477](#477)) ([7315589](7315589))
🎉 This PR is included in version 1.8.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
On affected clusters and clusters list tables, if you change per page or reset/apply filters, you will stay on the same page. Pages should be reset to 1 if you change the per page count or apply or remove a filter. This PR fixes those issues.