feat(Single rec page): Show risk of change info #498
Conversation
Implements https://issues.redhat.com/browse/OCPADVISOR-13. This enables the risk of change (resolution risk) section at the single recommendation page.
| @@ -0,0 +1,3 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export const strong = (str) => <strong>{str}</strong>; | |||
There was a problem hiding this comment.
This was done because the webpack build for cypress behaved a bit differently. In the previous implementation, there was a circular dependency which cypress webpack config wasn't able to resolve, and strong was evaluated to undefined. It's tricky and I can't say how to properly fix it, but this module separation resolves that.
Codecov ReportBase: 87.08% // Head: 87.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 87.08% 87.10% +0.02%
==========================================
Files 25 26 +1
Lines 1161 1163 +2
Branches 444 446 +2
==========================================
+ Hits 1011 1013 +2
Misses 150 150
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Tested it locally. Works as intended. LGTM |
# [1.9.0](v1.8.4...v1.9.0) (2023-01-17) ### Features * **Single rec page:** Show risk of change info ([#498](#498)) ([39d546b](39d546b))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements https://issues.redhat.com/browse/OCPADVISOR-13.
This enables the risk of change (resolution risk) section at the single recommendation page.
How to test
Run the PR locally and navigate to /openshift/insights/advisor/recommendations. Select any recommendation and move to the details page. The "Risk of change" header must be rendered with all the additional labels and information. You can also check the API response from
GET /rule/IDendpoint and check theresolution_riskinteger value corresponds to the correct label (Very low = 1, Low = 2, Moderate = 3, High = 4).Screenshots