feat(Recs list): Risk of change details section #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements https://issues.redhat.com/browse/OCPADVISOR-66. This adds a new section to expanded rule content on the recommendations list table. The section shows information about the risk of change for the given rule.
ikerreyes
approved these changes
Jan 19, 2023
gkarat
pushed a commit
that referenced
this pull request
Jan 19, 2023
# [1.11.0](v1.10.0...v1.11.0) (2023-01-19) ### Features * **Recs list:** Risk of change details section ([#507](#507)) ([8e541e8](8e541e8))
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://issues.redhat.com/browse/OCPADVISOR-66.
This adds a new section to expanded rule content on the recommendations list table. The section shows information about the risk of change for the given rule.
How to test
Navigate to /openshift/insights/advisor/recommendations. Check that for the rows that have risk of change value, the expanded information contains the risk of change section. For the rules that do not have (currently, all external rules have risk of change, but the tests cover this case), the section must be empty in the expanded content.
Screenshots