fix(OCPADVISOR-59): Fix not loading pages #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the bug when the users navigated to the cluster or recommendation details page for the second and further times and couldn't see data loaded.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 88.03% 85.00% -3.04%
==========================================
Files 25 25
Lines 1162 1160 -2
Branches 450 450
==========================================
- Hits 1023 986 -37
- Misses 139 174 +35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gkarat
pushed a commit
that referenced
this pull request
Mar 9, 2023
## [1.11.1](v1.11.0...v1.11.1) (2023-03-09) ### Bug Fixes * **OCPADVISOR-59:** Fix not loading pages ([#528](#528)) ([970267c](970267c))
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/OCPADVISOR-59.
This should fix the bug when the users navigated to the cluster or recommendation details page for the second and further times and couldn't see data loaded.
Screencast.from.03-08-2023.01.48.38.PM.webm
How to test
Navigate to recommendation/id or cluster/id pages. Go back to the recommendations/clusters list table via breadcrumbs. Go again to any of the details pages. The end page should load fine (whereas for example in production it does not currently).