-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(OCPADVISOR-73): Track clicks on the Upgrade risks tab #557
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 87.87% 88.73% +0.85%
==========================================
Files 32 33 +1
Lines 1287 1305 +18
Branches 505 512 +7
==========================================
+ Hits 1131 1158 +27
+ Misses 156 147 -9
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
id: clusterId, | ||
}); | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this useEffect, really nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [1.16.0](v1.15.2...v1.16.0) (2023-04-24) ### Features * **OCPADVISOR-73:** Track clicks on the Upgrade risks tab ([#557](#557)) ([468e0cc](468e0cc))
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements https://issues.redhat.com/browse/OCPADVISOR-73.
Send analytics to segment.io (Pendo) when users click on "Upgrade risks" tab or access the page via the
/clusters/%id?active_tab=upgrade_risks
link. UI must include two parameters to the request: cluster_id of the browsed cluster and whether the upgrade is recommended or not. The latter is obtained from the GET /upgrade-risks-prediction endpoint.How to test
?active_tab=upgrade_risks
and repeat the previous step.