Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(OCPADVISOR-88): Hide upgrade risks for managed clusters #560

Merged
merged 4 commits into from
Apr 25, 2023
Merged

feat(OCPADVISOR-88): Hide upgrade risks for managed clusters #560

merged 4 commits into from
Apr 25, 2023

Conversation

gkarat
Copy link
Collaborator

@gkarat gkarat commented Apr 25, 2023 •
edited
Loading

Implements https://issues.redhat.com/browse/OCPADVISOR-88.

This makes the cluster details page hide all the upgrade risks-related features for managed clusters. The info about the cluster status is already available from the GET /%clusterId/info endpoint.

How to test

  1. Deploy the PR with npm run start:proxy:beta
  2. Navigate to https://stage.foo.redhat.com:1337/preview/openshift/insights/advisor/clusters
  3. Use insights-qa profile
  4. Select one of the managed clusters, e.g., "CCX Managed ARO"
  5. Verify that there are no upgrade risks shown (banner and tab). Also, there should be no outgoing network request to GET /upgrade-risks-prediction.
  6. Check that the feature is enabled for non-managed clusters.

@gkarat gkarat marked this pull request as ready for review April 25, 2023 10:26
@gkarat gkarat requested a review from a team as a code owner April 25, 2023 10:26
@gkarat gkarat self-assigned this Apr 25, 2023
@gkarat gkarat added the enhancement New feature or request label Apr 25, 2023
Fewwy
Fewwy approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkarat gkarat merged commit 084cccf into RedHatInsights:master Apr 25, 2023
gkarat pushed a commit that referenced this pull request Apr 25, 2023
@semantic-release-bot
chore(release): 1.17.0 [skip ci]
83a3f33 
# [1.17.0](v1.16.2...v1.17.0) (2023-04-25)

### Features

* **OCPADVISOR-88:** Hide upgrade risks for managed clusters ([#560](#560)) ([084cccf](084cccf))
@gkarat
Copy link
Collaborator Author

gkarat commented Apr 25, 2023

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fewwy Fewwy Fewwy approved these changes

Assignees

@gkarat gkarat

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkarat @Fewwy