Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OCPADVISOR-82): Fix "affected clusters" link #561

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

gkarat
Copy link
Collaborator

@gkarat gkarat commented Apr 25, 2023

Fixes https://issues.redhat.com/browse/OCPADVISOR-82.

This upgrade the advisor-components dependency where the links were updated to accomodate upgrade of react-router-dom to v6 and using the correct links format.

How to test

  1. With this PR, run npm run start:proxy:beta
  2. Navigate to https://stage.foo.redhat.com:1337/preview/openshift/insights/advisor/recommendations
  3. Expand content for any of the recommendation that hits at least 1 cluster
  4. Click on "View affected clusters" link below. Check that you are redirect to the recommendation details page.

This upgrade the advisor-components dependency where the links were updated to
accomodate upgrade of react-router-dom to v6 and using the correct links
format.
@gkarat gkarat added the bug Something isn't working label Apr 25, 2023
@gkarat gkarat self-assigned this Apr 25, 2023
@gkarat gkarat requested a review from a team as a code owner April 25, 2023 13:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (bfa0b5f) 88.73% compared to head (2d28d15) 88.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   88.73%   88.80%   +0.06%     
==========================================
  Files          33       34       +1     
  Lines        1305     1313       +8     
  Branches      512      514       +2     
==========================================
+ Hits         1158     1166       +8     
  Misses        147      147              

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkarat gkarat merged commit 7a74b7c into RedHatInsights:master Apr 27, 2023
gkarat pushed a commit that referenced this pull request Apr 27, 2023
## [1.17.1](v1.17.0...v1.17.1) (2023-04-27)

### Bug Fixes

* **OCPADVISOR-82:** Fix "affected clusters" link ([#561](#561)) ([7a74b7c](7a74b7c))
@gkarat
Copy link
Collaborator Author

gkarat commented Apr 27, 2023

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants