Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(OCPADVISOR-89): Fix active tab handling #565

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix(OCPADVISOR-89): Fix active tab handling #565

merged 1 commit into from
Apr 27, 2023

Conversation

gkarat
Copy link
Collaborator

@gkarat gkarat commented Apr 26, 2023

Fixes https://issues.redhat.com/browse/OCPADVISOR-89.

This fixes incorrect active tab handling provided by active_tab URL parameter.

How to test

  1. Deploy with npm run start:proxy:beta,
  2. Navigate to any cluster (cluster details page), e.g. https://stage.foo.redhat.com:1337/beta/openshift/insights/advisor/clusters/bc960900-da34-11ed-b4ef-5405db17362c (under insights-qa),
  3. Click on the upgrade risks tab and refresh the page,
  4. Check that 1) the refreshed page keeps upgrade risks tab open, 2) URL contains active_tab=upgrade_risks,
  5. Click on the recommendations page and refresh the page,
  6. Check that 1) the refreshed page keeps recommendations tab open, 2) URL contains active_tab=recommendations.

@gkarat gkarat added the bug Something isn't working label Apr 26, 2023
@gkarat gkarat self-assigned this Apr 26, 2023
@gkarat gkarat requested a review from a team as a code owner April 26, 2023 10:49
AsToNlele
AsToNlele approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job works great 😄

@gkarat gkarat merged commit b1717da into RedHatInsights:master Apr 27, 2023
gkarat pushed a commit that referenced this pull request Apr 27, 2023
@semantic-release-bot
chore(release): 1.17.2 [skip ci]
35aed85 
## [1.17.2](v1.17.1...v1.17.2) (2023-04-27)

### Bug Fixes

* **OCPADVISOR-89:** Fix active tab handling ([#565](#565)) ([b1717da](b1717da))
@gkarat
Copy link
Collaborator Author

gkarat commented Apr 27, 2023

🎉 This PR is included in version 1.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsToNlele AsToNlele AsToNlele approved these changes

Assignees

@gkarat gkarat

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkarat @AsToNlele