Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Templates): Update templates page header #960

Merged
merged 2 commits into from
Feb 15, 2023
Merged

feat(Templates): Update templates page header #960

merged 2 commits into from
Feb 15, 2023

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Feb 15, 2023 •
edited
Loading

Description

Associated Jira ticket: SPM-1548
Associated mockup: https://www.sketch.com/s/598ac9a1-16ce-47b1-8515-e79928a2b2fb/a/ELywAxO

  • update header title in Patch Templates page from 'Patch template' to 'Templates'.
  • add popover next to header title
  • update frontend.yml with current information

How to test the PR

Verify correspondence of Template list page header with the mockup.

Mockup

Screenshot from 2023-02-15 21-14-58

Before the change

Screenshot from 2023-02-15 21-13-32

After the change

Screenshot from 2023-02-15 21-07-51

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@leSamo leSamo requested a review from a team as a code owner February 15, 2023 20:47
mkholjuraev
mkholjuraev approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @leSamo .

@leSamo leSamo merged commit c11f4f9 into master Feb 15, 2023
mkholjuraev pushed a commit that referenced this pull request Feb 15, 2023
@semantic-release-bot
chore(release): 1.59.0
01d8773 
# [1.59.0](v1.58.2...v1.59.0) (2023-02-15)

### Bug Fixes

* Fix patch templates page not receiving redux updates ([#958](#958)) ([41668f2](41668f2))

### Features

* **Templates:** Update templates page header ([#960](#960)) ([c11f4f9](c11f4f9))
@mkholjuraev
Copy link
Contributor

🎉 This PR is included in version 1.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

karelhala pushed a commit to RedHatInsights/patchman-ui-build that referenced this pull request Feb 15, 2023
chore(release): 1.59.0
8c7d1e5 
# [1.59.0](RedHatInsights/patchman-ui@v1.58.2...v1.59.0) (2023-02-15)

### Bug Fixes

* Fix patch templates page not receiving redux updates ([#958](RedHatInsights/patchman-ui#958)) ([41668f2](RedHatInsights/patchman-ui@41668f2))

### Features

* **Templates:** Update templates page header ([#960](RedHatInsights/patchman-ui#960)) ([c11f4f9](RedHatInsights/patchman-ui@c11f4f9))
@johnsonm325 johnsonm325 deleted the update-templates-header branch May 8, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkholjuraev mkholjuraev mkholjuraev approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leSamo @mkholjuraev