Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monospace & tabular numbers: 0 incorrectly has a slash #53

Open
garrett opened this issue Jan 9, 2023 · 4 comments
Open

Monospace & tabular numbers: 0 incorrectly has a slash #53

garrett opened this issue Jan 9, 2023 · 4 comments

Comments

@garrett
Copy link

garrett commented Jan 9, 2023

When enabling tabular numbers with RedHatFont in PatternFly in Cockpit, we've noticed that the 0 (zero) gains a slash (/) which is not only ugly, but makes it look like an 8, especially for people who have astigmatism (including myself), making this not just a visual problem but an accessibility issue.

Tabular numbers and slashed zero are two different font variant settings. Whereas RedHatFont groups the two features under tabular-numbers.

These are both exposed in font-variant-numeric in CSS: https://developer.mozilla.org/en-US/docs/Web/CSS/font-variant-numeric#values

font-variant-numeric takes several values; it's often just one at a time, but it can be used space-separated too. Relevant examples:

font-variant-numeric: tabular-nums;
font-variant-numeric: slashed-zero;
font-variant-numeric: tabular-nums slashed-zero;

What is asked for is the first (tabular-nums) but we're seeing effects as if we asked for tabular-nums slashed-zero.

We're tracking this @ cockpit-project/cockpit#18125 but really need this fixed upstream here @ RedHatFont (and then need the fix included in PatternFly afterward).

@garrett
Copy link
Author

garrett commented Jan 9, 2023

Here's an example screenshot:

image

@garrett
Copy link
Author

garrett commented Jan 9, 2023

This same problem also seems to exist in "Red Hat Mono".

@garrett garrett changed the title Tabular numbers: 0 incorrectly has a slash Monospace & tabular numbers: 0 incorrectly has a slash Jan 9, 2023
@libbylevi
Copy link

The slashed zero was a stylistic choice to differentiate zero from a capital O in the mono font, and then we decided to use the same mono numerals as the tabular numerals in the proportional fonts, for consistency across the family.

We could separate the slashed zero from the tabular number variables in the proportional fonts, but it would need to be part of an update with the typographer, and we don't have that in the plan for this year. I'll keep this in mind for next time we do an update.

@juhp
Copy link

juhp commented Nov 11, 2024

Any further update (since redhat-fonts is planned to be default font in RHEL 10)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants