-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛐 Worship the OCaml module system #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favonia
reviewed
Jul 9, 2022
Co-authored-by: favonia <favonia@gmail.com>
favonia
reviewed
Jul 9, 2022
Just wanted to add that, under the records=modules Thought, these two approaches should be isomorphic. I hope we can fix this problem at least in the languages/tools we created. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two changes:
Replace the
handler
records with modules. I found (experimentally) while hackingalgaett
that it is a lot less painful to program the handlers with modules than it is to write out the records. Features likeinclude
andopen
are useful, and I would not discount reducing the stress of being several parenthesis/brace delimiter levels into a gnarly piece of code.I have refactored the modules so that the main signatures are declared (and documented) just once. This removes a lot of duplication that is annoying when refactoring code. It also means that if documentation is generated for the private/internal modules, the documentation comments will appear for these as well. Sometimes we wish to expose a different public interface than the private interface (but I didn't notice that in this library); that too can be incorporated, through judicious use of
include
.Let me know if you have any feedback about these changes, or if you don't like it for some reason. Thanks!