Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core framework should skip non-installed implementations #45

Open
btgoodwin opened this issue Nov 19, 2020 · 0 comments
Open

Core framework should skip non-installed implementations #45

btgoodwin opened this issue Nov 19, 2020 · 0 comments

Comments

@btgoodwin
Copy link

The core framework currently evaluates the implementations listed in the SPD in order and on the first viable target device, will attempt to load the binary without regard to whether or not the binary actually exists. This results in errors at runtime about being unable to load implementations even if there are other viable implementations available.

One example of this is rh.HardLimit. If for some reason the executable device in the system's processor_name doesn't match either x86 or x86_64, the core framework moves on to the Java implementation (as it is next in the SPD). With all criteria met, the core framework then attempts to load the entrypoint for the Java implementation and fails right there, without then moving on to the Python implementation, or some other implementation the user has added to the SPD.

I propose that one of the first things the core framework should do is check for and then skip any implementation whose entrypoint does not exist on disk. This would allow for the framework to attempt all possible implementations without the user having to delete those implementation references from the SPD as a work-around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant