Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client.Delete() behaves opposite to spec for v1.4 and v1.6 #82

Closed
filipecosta90 opened this issue Aug 17, 2020 · 0 comments · Fixed by #80
Closed

Client.Delete() behaves opposite to spec for v1.4 and v1.6 #82

filipecosta90 opened this issue Aug 17, 2020 · 0 comments · Fixed by #80
Assignees
@filipecosta90
Labels
bug

Comments

@filipecosta90
Copy link
Collaborator

filipecosta90 commented Aug 17, 2020 •
edited
Loading

Following @TropicalPenguin report.
As of current master Client.Delete() is deleting the underlying actual document when we set deleteDocument to false, and retaining the document when we set deleteDocument to true.
See https://github.com/RediSearch/redisearch-go/blob/master/redisearch/client.go#L371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipecosta90 filipecosta90

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@filipecosta90