Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slowlog returns 'No data' for Redis 3.0.6 #33

Closed
wangxin0529 opened this issue Aug 6, 2020 · 6 comments · Fixed by #40
Closed

Slowlog returns 'No data' for Redis 3.0.6 #33

wangxin0529 opened this issue Aug 6, 2020 · 6 comments · Fixed by #40
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wangxin0529
Copy link

wangxin0529 commented Aug 6, 2020

image

slowlog get has results

image

----------------------------------------------------------------------------------------------------
if slowlog get is empty list
image
it will be normal
My Redis version is 3.0.6 ,grafana version is 7.0.3

@mikhail-vl mikhail-vl self-assigned this Aug 6, 2020
@mikhail-vl mikhail-vl added the bug Something isn't working label Aug 6, 2020
@mikhail-vl mikhail-vl added this to the Version 1.2 milestone Aug 6, 2020
@mikhail-vl
Copy link
Contributor

Hello @wangxin0529,

Thank you for trying the Redis Datasource and the issue. The Slowlog command (https://redis.io/commands/slowlog) was enhanced in Redis version 4 and the command output in version 3 is different.
I will test on version 3.0.6 and let you know when ready.

@mikhail-vl mikhail-vl changed the title slowlog no data Slowlog returns 'No data' for Redis 3.0.6 Aug 6, 2020
@wangxin0529
Copy link
Author

Thank you for trying the Redis Datasource and the issue. The Slowlog command (https://redis.io/commands/slowlog) was enhanced in Redis version 4 and the command output in version 3 is different.

OK,I will test on version 4.x

@marcossv9
Copy link

Hi,

Same issue with Redis 2.8.24 here.

If I run the command from redis-cli it works.

Any help would be appreciated.

Thanks,

@mikhail-vl
Copy link
Contributor

@wangxin0529 and @marcossv9 the issue is fixed in the master. Please follow BUILD (https://github.com/RedisTimeSeries/grafana-redis-datasource/blob/master/BUILD.md) instructions to build it yourself.

The datasource will be updated in the Grafana repository soon.

@wangxin0529
Copy link
Author

@mikhailredis When will it could be updated in the Grafana repository?

@mikhail-vl
Copy link
Contributor

I am finishing the 1.2.0 release with new features and will submit it for review next week.
Can you wait or build it yourself following BUILD instruction meanwhile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants