Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Redis Datasource timeout when one is not reachable #73

Closed
pab1it0 opened this issue Oct 13, 2020 · 5 comments · Fixed by #160
Closed

All Redis Datasource timeout when one is not reachable #73

pab1it0 opened this issue Oct 13, 2020 · 5 comments · Fixed by #160
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pab1it0
Copy link

pab1it0 commented Oct 13, 2020

Describe the bug

All Datasource timeout when one is not reachable

Version

1.2.0

Steps to reproduce

  1. Create more than one redis datasource, one that isn't reachable
  2. Create dashboard for each datasource.
  3. Goto the reachable datasource's dashboard and refresh -> Dashboard is updated with metrics
  4. Goto the unreachable datasource's dashboard and refresh -> Dashboard freezes.
  5. Go back to reachable datasource's dashboard and refresh -> Dashboard freezes.

Expected behavior

Dashboard with reachable datasource should fetch metrics indifferently of other datasource's state.

@pab1it0
Copy link
Author

pab1it0 commented Oct 13, 2020

@mikhailredis FYI.

@mikhail-vl mikhail-vl self-assigned this Oct 13, 2020
@mikhail-vl mikhail-vl added the bug Something isn't working label Oct 13, 2020
@mikhail-vl mikhail-vl added this to the Version 1.2 milestone Oct 13, 2020
@mikhail-vl
Copy link
Contributor

@pab1it0 Thank you for submitting the issue. I will check and get back to you.

@mikhail-vl mikhail-vl modified the milestones: Version 1.2, Version 1.3 Oct 25, 2020
@mikhail-vl mikhail-vl modified the milestones: Version 1.3, Version 1.3.1 Dec 20, 2020
@mikhail-vl
Copy link
Contributor

@pab1it0 I am sorry for the delay. I found the issue with the timeout, which is fixed in the upcoming release. This helps with this issue, but still, Redis Data Source is blocking when trying to open new connections.

I will investigate further.

@mikhail-vl
Copy link
Contributor

Opened the issue for Grafana SDK: grafana/grafana-plugin-sdk-go#248

@mikhail-vl mikhail-vl modified the milestones: Version 1.3.1, Version 1.4 Jan 16, 2021
@mikhail-vl
Copy link
Contributor

PR submitted: grafana/grafana-plugin-sdk-go#251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants