Skip to content

Conversation

pawelangelow
Copy link
Collaborator

@pawelangelow pawelangelow commented Apr 24, 2025

No tests, as we don't have a cool way to test it 😿 If you have something in mind - feel free to share it, if not, it's a good candidate for E2E.

Here's a preview:

Screen.Recording.2025-04-24.at.15.25.48.mov

And how it looked before:

Screen.Recording.2025-04-24.at.15.31.46.mov

KIvanow
KIvanow previously approved these changes Apr 24, 2025
dantovska
dantovska previously approved these changes Apr 24, 2025
@KIvanow
Copy link
Contributor

KIvanow commented Apr 24, 2025

@pawelangelow the FE tests have starting failing though.

I agree it would be a great candidate for e2e later on :)

@pawelangelow pawelangelow dismissed stale reviews from dantovska and KIvanow via ac6a607 April 24, 2025 13:06
@pawelangelow
Copy link
Collaborator Author

@pawelangelow the FE tests have starting failing though.

I agree it would be a great candidate for e2e later on :)

Yes, it turns out there are store tests. IMO, this is not the way to test such functionality, as only the store gets tested, not the integration of the visual part with the store, but still, they needed to be fixed.

@KIvanow
Copy link
Contributor

KIvanow commented Apr 25, 2025

@pawelangelow the FE tests have starting failing though.
I agree it would be a great candidate for e2e later on :)

Yes, it turns out there are store tests. IMO, this is not the way to test such functionality, as only the store gets tested, not the integration of the visual part with the store, but still, they needed to be fixed.

I agree. Overall our FE tests need rethinking. They produce too many false positives/negatives

@pawelangelow pawelangelow merged commit 6734ffd into main Apr 25, 2025
61 of 64 checks passed
@pawelangelow pawelangelow deleted the feature/RI-6945-always-open-jsons-with-default-editor branch April 25, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants