-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite #6
Test suite #6
Conversation
@hootnot waiting for the fat lady to sing, but this looks great! |
do you want me to fix README from md to rst ? |
That'd be @tom-christie. |
rst makes more sense given your argument and experience, thanks for that too. I'll merge as is unless you plan to add coverage (yes please!). |
…o test-suite ly if it merges an updated upstream into a topic branch.
Fixed the setEncoder/setDecoder internal links. Should be it now. You can merge now if you like. To setup coverage you need to modify .travis.yml with a key from coveralls.io . You are the boss! so you have to do this because of key related stuf. Lets handle this one first |
Thanks again -merging and starting to think about releasing the next version codenamed "hootnot" :) |
... I would be honoured :-), saw the 95% coverage too. A few extra tests and you have it 100%. The version still sits on 2.7, that is because that info is retrieved from pypi and not from the master as I wrote in the PR. So when you upload a new release that is fixed. |
In case I forgot to say it, thank you. After taking the project for a test drive, it feels like I moved from to Getting this atm, but I'm sure it is something that I missed: $ pip install rejson
Collecting rejson
Downloading rejson-0.2.0.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/pip-build-EobKFa/rejson/setup.py", line 22, in <module>
requirements = map(str.strip, open("requirements.txt").readlines())
IOError: [Errno 2] No such file or directory: 'requirements.txt'
----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-EobKFa/rejson/ |
Personally I deploy to pypi from Travis: bump the version in __init__, update your master, tag it and you are done.
This setup is partially based on work of Tom Christie, @tomchristie, author of the Django Rest Framework, he wrote an article about depoying to pypi: https://tom-christie.github.io/articles/pypi/. For some of my own packages I've extended that a lot.
Travis has some annoying differences between the different environments. Sometimes you run into them