Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for x-example vendor extension #186

Closed
manuc66 opened this issue Jan 25, 2017 · 13 comments
Closed

Support for x-example vendor extension #186

manuc66 opened this issue Jan 25, 2017 · 13 comments

Comments

@manuc66
Copy link

manuc66 commented Jan 25, 2017

Hi,

I think it would be nice to support the x-example vendor extension from Apiary

Thanks

@RomanHotsiy
Copy link
Member

@manuc66 yes, this seems to be an easy change.
Will add once have some time

@jeremycohensolal
Copy link

+1

@philsturgeon
Copy link
Contributor

Hey! Did this ever get done? I'm trying to work with Open API v2.0 and Dredd v4.1.1, and there is an impassible conflict.

Dredd allows x-example but ReDoc requires example, so I can either use ReDoc or Dredd.

@RomanHotsiy
Copy link
Member

@philsturgeon, yes, this will definitely get done.
If you want to get this faster feel free to open PR. Let me know if you need any help.

@philsturgeon
Copy link
Contributor

@RomanGotsiy right on. Scroll up your inbox a little further, already tried. 😅 #304

@adamaltman
Copy link
Member

@philsturgeon Roman is on vacation. He'll be able to help you out when he returns at the beginning of August.

@RomanHotsiy
Copy link
Member

Thanks, @adamaltman for covering my back :)
Between ✈️ and 👜 I've found some time to look into this issue (#304) and just fixed it :)

@philsturgeon
Copy link
Contributor

Thanks for the heads up @adamaltman, and thank you for the fix @RomanGotsiy!

@RomanHotsiy
Copy link
Member

@philsturgeon so are you going or maybe in process of creating a PR? Or I should handle it?

@philsturgeon
Copy link
Contributor

I've had a few brief attempts but not got very far. If you could knock this out I'd appreciate it!

@RomanHotsiy
Copy link
Member

OK! I will try to include this feature in the next-week release as I've just published new version v1.17.0

@JonKohler
Copy link

This should have been closed when #297 got merged, here: f792273

I checked the latest redoc 2.0 and this for sure works

@lornajane
Copy link
Contributor

Looks fixed, so I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants