-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: encoding issue in CDN responses #2130
Merged
AlexVarchuk
merged 1 commit into
Redocly:master
from
bparmentier:fix-cdn-files-encoding
Aug 18, 2022
Merged
fix: encoding issue in CDN responses #2130
AlexVarchuk
merged 1 commit into
Redocly:master
from
bparmentier:fix-cdn-files-encoding
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When downloading the redoc JS from redoc.ly CDN (e.g. https://cdn.redoc.ly/redoc/latest/bundles/redoc.standalone.js) the Content-Type header in the response is missing 'charset=utf-8', causing the file to be displayed with garbled characters.
AlexVarchuk
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bparmentier. Thank you a lot for your contribution 🙌
This was referenced Jul 16, 2024
This was referenced Jul 25, 2024
This was referenced Aug 1, 2024
This was referenced Aug 19, 2024
This was referenced Sep 23, 2024
This was referenced Oct 1, 2024
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
When downloading the redoc JS from redoc.ly CDN (e.g. https://cdn.redoc.ly/redoc/latest/bundles/redoc.standalone.js) the
Content-Type
header in the response is missing'charset=utf-8'
, causing the file to be displayed with garbled characters.I faced the issue in my project and found that it was indirectly reported multiple times over the years, as can be seen in #29.
The solution proposed in #213 (comment) is just a workaround and I'm actually not sure why it works for other people because according to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#attr-charset, "UTF-8 is the only valid encoding for HTML5 documents" anyway.
Reference
aws-cli
doesn't automatically detect the charset when uploading files Unable to setcharset
when mime-types are guessed (S3) aws/aws-cli#1346Testing
Open the above URL in a browser and search for e.g.
.ellipsis:after
. The value ofcontent
should be displayed asinstead of