Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG 1.3.1 - Menu roles does not follow spec #2227

Closed
dagfs opened this issue Dec 6, 2022 · 0 comments
Closed

WCAG 1.3.1 - Menu roles does not follow spec #2227

dagfs opened this issue Dec 6, 2022 · 0 comments

Comments

@dagfs
Copy link
Contributor

dagfs commented Dec 6, 2022

Describe the problem to be solved
As per reported by the SiteImprove extension the menu have placed the menuitem role wrong.

Describe the solution you'd like
I'd like for us to move the role from the label to the li element in the menu.

I'm not quite sure if this is actually a problem or not. I've asked around a bit, still waiting for some answers. I'll make a PR for it in about 12 hours.

Describe alternatives you've considered

  • arguing that the siteimprove report is to harsh in the situation

Additional context

This issue is related to my previous issue #2223 as part of the same improvments

This issue relates to the tracking WCAG issue #1279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants