-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use h2/h3 for headings instead of h1/h2 for better seo #2514
Conversation
Hey @RomanHotsiy, would you like to spend some time to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update e2e tests. A couple of them failed in menu.e2e.ts
Thanks for the notifications. |
@maxkrumpe please merge your PR when you are ready. |
@AlexVarchuk I don't have write access to the repository so unfortunately I cannot merge the PR. Do you have write access to it to merge the PR? |
@maxkrumpe Done. Thank you very much for your contribution. 🙌 |
@AlexVarchuk thank you too for reviewing the PR. |
What/Why/How?
Changed headings from h1/h2 to h2/h3 for content items for a better seo behavior.
Because of multiple h1 tags Google will list the pages more bad than with a better structured layout.
Reference
See #2513
Tests
All tests were successfully run (unit tests).
We do not consider issues because only the headings were changed.
Only the look an feel (smaller headings for tags) is a bit different (see screenshot).
Screenshots (optional)
Check yourself