-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create-efx): Move dependencies to peerDependencies and remove unused package from devDependencies #472
Merged
Sarin-Udompanish
merged 5 commits into
v6
from
fix/create-efx-move-elf-core-in-template-to-peer-dependencies
Sep 28, 2022
Merged
fix(create-efx): Move dependencies to peerDependencies and remove unused package from devDependencies #472
Sarin-Udompanish
merged 5 commits into
v6
from
fix/create-efx-move-elf-core-in-template-to-peer-dependencies
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
Sarin-Udompanish
changed the title
Fix/create efx move refinitiv-ui core in template to peer dependencies
Move dependencies to peerDependencies and remove unused package from devDependencies
Sep 28, 2022
Kudos, SonarCloud Quality Gate passed! |
Theeraphat-Sorasetsakul
approved these changes
Sep 28, 2022
Sarin-Udompanish
changed the title
Move dependencies to peerDependencies and remove unused package from devDependencies
fix(create-efx): Move dependencies to peerDependencies and remove unused package from devDependencies
Sep 28, 2022
bualoy-napat
deleted the
fix/create-efx-move-elf-core-in-template-to-peer-dependencies
branch
October 18, 2022 07:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@refinitiv-ui/core in template should be in peer dependencies to resolve multiple versions of core issues.
This PR also