Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Connector validators #33

Open
bodja opened this issue Nov 4, 2024 · 0 comments
Open

Introduce Connector validators #33

bodja opened this issue Nov 4, 2024 · 0 comments

Comments

@bodja
Copy link
Contributor

bodja commented Nov 4, 2024

Currently Connector.is_valid method solely relies on the kafka-connect REST API, which does some basic sanity checks but some things are not considered, e.g. skip.messages.without.change will only work when REPLICA IDENTITY of the table is set to FULL.
Potentially there are other usecases where one would want to write manual validation of the configuration.

Currently it is possible to override is_valid method which might be good enough. Another option would be to extend Connector class with the validators functionality.

  • Should we prevent the submission if validators fail by default?
  • Should we introduce a configuration which allows to control this behavior (self check before the submission)? Currently we consider the validation as a one of the deployment step ./manage.py kafka_connect --validate --publish --check-status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant