Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dashboard Widget - not playing pls playlists #583

Closed
kenda opened this issue Nov 25, 2022 · 2 comments
Closed

[BUG] Dashboard Widget - not playing pls playlists #583

kenda opened this issue Nov 25, 2022 · 2 comments

Comments

@kenda
Copy link

kenda commented Nov 25, 2022

Describe the bug
I have a couple of pls playlists which are working fine in the app itself. But they are not playing in the dashboard widget.

I found this special handling here:

audioplayer/js/dashboard.js

Lines 355 to 358 in a7984dc

if (itemData['mim'] === 'audio/mpegurl' || itemData['mim'] === 'audio/x-scpls' || itemData['mim'] === 'application/xspf+xml') {
streamUrl = itemData['lin'];
jsondata.data = [];
break;
Which seems to handle the playlists like pls. Not sure if the break might be the problem already.

Expected behavior
After selecting a playlist, I should be able to play it.

Versions:

  • Nextcloud: 25.0.1
  • Audioplayer 3.3.1
@kenda
Copy link
Author

kenda commented Dec 17, 2022

I had a little look at it and it seems that the break is basically preventing the following CSP issue that the streams are not allowed because of the media-src CSP. The app itself is adding a wildcard here but I doubt that this is possible for the dashboard page.

@Rello
Copy link
Owner

Rello commented Dec 11, 2023

thats correct here. the app itself can set alternative CSP - to do this for the dashboard, which includes other apps also, would be fatal

@Rello Rello closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants