Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Linux #75

Open
jackz314 opened this issue Dec 29, 2020 · 2 comments
Open

Support for Linux #75

jackz314 opened this issue Dec 29, 2020 · 2 comments

Comments

@jackz314
Copy link

jackz314 commented Dec 29, 2020

I recently came across this repo and I'm glad it's still being actively maintained. I run my games on Linux so I adapted this repo to work with Linux on my fork here.

I did this quickly and didn't really test or optimize thoroughly because I needed to use it in a project quickly, it also abandoned Windows support for simplicity's sake. In the spirit of #28, I was wondering if the maintainers or anyone would like to merge the two codebases together so that this SDK would have both Windows and Linux support. My code for Linux uses mmap, which has basically the same workflow as Windows' SharedMemory. I'd love to start merging myself but I'm not very familiar with Windows and cross-platform support. A simple temporary merge, for now, could just use a different folder for Linux.

I also have to say that because this was done in a short period of time and I'm not really familiar with scs plugins, there could be serious bugs hidden somewhere, I tested out simple polling and it seems to work fine, but who knows what could be wrong.

On a side note, I added a simple incomplete Python client that contains some of the important fields I used in my project, if anyone would like to complete it that would be awesome.

@RenCloud
Copy link
Owner

RenCloud commented Jan 5, 2021

Hey, this sounds very nice. mmap should be fine for now. Currently I will unfortunately not have the time to test and merge this, but I will work on it when I have time again in a few month.

Linux support has been planned for a long time, so I'm glad someone has been working on it.

However, if someone has the time and the motivation until then to work on the merge, I would be happy about a PR.

@spikerguy
Copy link

Hey, this sounds very nice. mmap should be fine for now. Currently I will unfortunately not have the time to test and merge this, but I will work on it when I have time again in a few month.

Linux support has been planned for a long time, so I'm glad someone has been working on it.

However, if someone has the time and the motivation until then to work on the merge, I would be happy about a PR.

I am planning to rebase @jackz314 works and maybe make a PR to this as I am testing it and it works fine when using it with monocoque project which can output data to the hardware.

We just tested it today and it does work as expected but need some changes.

I have joined the discord too for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants